Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update socat test image #355

Merged
merged 1 commit into from
May 27, 2022
Merged

Update socat test image #355

merged 1 commit into from
May 27, 2022

Conversation

yselkowitz
Copy link
Contributor

What type of PR is this?
/kind failing-test

What this PR does / why we need it:

This updates the alpine/socat test image to the latest version, which also adds multi-architecture support.

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

NONE

@yselkowitz
Update socat test image
81e7791 
This version also adds multi-architecture support.
@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels May 27, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @yselkowitz!

It looks like this is your first PR to kubernetes-csi/csi-driver-host-path 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes-csi/csi-driver-host-path has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label May 27, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @yselkowitz. Thanks for your PR.

I'm waiting for a kubernetes-csi member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label May 27, 2022
@yselkowitz
Copy link
Contributor Author

/assign @jsafrane

@yselkowitz yselkowitz mentioned this pull request May 27, 2022
Merged
@jsafrane
Copy link
Contributor

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels May 27, 2022
@jsafrane
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jsafrane, yselkowitz

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit 96bd620 into kubernetes-csi:master May 27, 2022
yselkowitz added a commit to yselkowitz/kubernetes that referenced this pull request Jun 2, 2022
@yselkowitz
storage e2e: hostpath driver v1.8.0
9c2be70 
Changes includes results of the following command:

test/e2e/testing-manifests/storage-csi$ ./update-hostpath.sh v1.8.0

This also includes backports from the following post-release commits:
kubernetes-csi/csi-driver-host-path#355
kubernetes-csi/csi-driver-host-path#357

Also includes a manual update of the busybox image to match the tag used
elsewhere in kubernetes e2e.
@yselkowitz yselkowitz deleted the update-socat branch June 7, 2022 05:16
muyangren2 pushed a commit to muyangren2/kubernetes that referenced this pull request Jul 14, 2022
@yselkowitz @muyangren2
storage e2e: hostpath driver v1.8.0
5546512 
Changes includes results of the following command:

test/e2e/testing-manifests/storage-csi$ ./update-hostpath.sh v1.8.0

This also includes backports from the following post-release commits:
kubernetes-csi/csi-driver-host-path#355
kubernetes-csi/csi-driver-host-path#357

Also includes a manual update of the busybox image to match the tag used
elsewhere in kubernetes e2e.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ggriffiths ggriffiths Awaiting requested review from ggriffiths

@xing-yang xing-yang Awaiting requested review from xing-yang

Assignees

@jsafrane jsafrane

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yselkowitz @k8s-ci-robot @jsafrane